Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some arena types/traits #173

Merged
merged 11 commits into from
May 11, 2024
Merged

Simplify some arena types/traits #173

merged 11 commits into from
May 11, 2024

Conversation

sampsyo
Copy link
Collaborator

@sampsyo sampsyo commented May 11, 2024

This is just paying off some technical debt w/r/t the little pool library that our flat representation is built upon and the way we convert between GFAStore (the mutable-size underlying data) and FlatGFA (the fixed-size references to in-place data).

I'm still not sure the current philosophy is good: namely, we are providing Pool and Store traits for existing types (vectors and slices) rather than creating our own newtypes. One consequence, for instance, is that you have to do pool.get_id(id) instead of pool[id], because pool is just a slice and slice[i] already means something. This is maybe worth revisiting someday.

@sampsyo sampsyo merged commit de556a9 into main May 11, 2024
6 checks passed
@sampsyo sampsyo deleted the store-mess branch May 11, 2024 18:55
sampsyo added a commit that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant