Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just paying off some technical debt w/r/t the little
pool
library that our flat representation is built upon and the way we convert betweenGFAStore
(the mutable-size underlying data) andFlatGFA
(the fixed-size references to in-place data).I'm still not sure the current philosophy is good: namely, we are providing
Pool
andStore
traits for existing types (vectors and slices) rather than creating our own newtypes. One consequence, for instance, is that you have to dopool.get_id(id)
instead ofpool[id]
, becausepool
is just a slice andslice[i]
already means something. This is maybe worth revisiting someday.