Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor in accordance to cursorless issue 1488 specs #1

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

rinOfTheStars
Copy link

@rinOfTheStars rinOfTheStars commented Jan 19, 2025

Should complete the first bullet point of cursorless-dev/cursorless#1488 as mentioned in the title. Things are a bit more hacky than I'd like, and in the future I might rewrite a good chunk of the code in order to only use git clone'd packages, but this is good enough for now. Obviously I can't test anything publishing related, so this is as far as I can take things.

Note that the parser packages listed in package.json are only the ones present in vscode-parse-tree (plus gdscript since I have a pr open for that which this makes somewhat irrelevant if I understand things correctly?); please lmk if the parser packages that were unique to this project should be readded!

Finally, please note that a few parser packages have had their versions upgraded. IIrc most of these were due to issues building older versions, as nearly all of the packages which are git clone'd in build.ts at runtime require special linking to build their .wasm file, which thankfully is present in fairly recent versions of said repos.

12 grammar packages do not build correctly yet. 5 failed to copy tree-sitter.json; the rest are special cases.
test if --shamefully-hoist fixes builtscript deployment woes
Seeing if v4 -> v3 fixes buildscript issues since v2 is substantially out-of-date
Using npm with pnpm setup is weird but it's what the only known working repo does so...
All wasm files build now (on my machine, at least)! Build still fails due to not being able to properly move said files to the output folder, however...
Said functionality was only used by tree-sitter-query and broke for unknown reasons when run by a GitHub Action; it's both cleaner and more functional to just clone the entire repository instead.
Also updated tree-sitter-agda and tree-sitter-elixir versions
@rinOfTheStars
Copy link
Author

@pokey Juat going to ping you here in case you've not seen this PR yet; feel free to take your time regardless though :c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant