forked from Gregoor/tree-sitter-wasms
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor in accordance to cursorless issue 1488 specs #1
Open
rinOfTheStars
wants to merge
27
commits into
cursorless-dev:main
Choose a base branch
from
rinOfTheStars:issue-1488-restructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor in accordance to cursorless issue 1488 specs #1
rinOfTheStars
wants to merge
27
commits into
cursorless-dev:main
from
rinOfTheStars:issue-1488-restructure
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 grammar packages do not build correctly yet. 5 failed to copy tree-sitter.json; the rest are special cases.
This reverts commit 4f294d4.
test if --shamefully-hoist fixes builtscript deployment woes
Seeing if v4 -> v3 fixes buildscript issues since v2 is substantially out-of-date
Using npm with pnpm setup is weird but it's what the only known working repo does so...
Yeah idk anymore
All wasm files build now (on my machine, at least)! Build still fails due to not being able to properly move said files to the output folder, however...
Said functionality was only used by tree-sitter-query and broke for unknown reasons when run by a GitHub Action; it's both cleaner and more functional to just clone the entire repository instead.
Also updated tree-sitter-agda and tree-sitter-elixir versions
@pokey Juat going to ping you here in case you've not seen this PR yet; feel free to take your time regardless though :c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should complete the first bullet point of cursorless-dev/cursorless#1488 as mentioned in the title. Things are a bit more hacky than I'd like, and in the future I might rewrite a good chunk of the code in order to only use
git clone
'd packages, but this is good enough for now. Obviously I can't test anything publishing related, so this is as far as I can take things.Note that the parser packages listed in
package.json
are only the ones present in vscode-parse-tree (plus gdscript since I have a pr open for that which this makes somewhat irrelevant if I understand things correctly?); please lmk if the parser packages that were unique to this project should be readded!Finally, please note that a few parser packages have had their versions upgraded. IIrc most of these were due to issues building older versions, as nearly all of the packages which are
git clone
'd inbuild.ts
at runtime require special linking to build their.wasm
file, which thankfully is present in fairly recent versions of said repos.