allow negative price impact to be shown in UI

curvefi · Jan 30, 2025 · 1db1a44 · 1db1a44
1 parent 324e821
commit 1db1a44
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/apps/main/src/lend/components/DetailInfoPriceImpact.tsx b/apps/main/src/lend/components/DetailInfoPriceImpact.tsx
@@ -16,7 +16,7 @@ const DetailInfoPriceImpact = ({
 }) => {
   const formattedPriceImpact = useMemo(() => {
     if (priceImpact === 'N/A') return 'N/A'
-    if (+priceImpact > 0) return `≈${formatNumber(priceImpact, { style: 'percent', maximumSignificantDigits: 4 })}`
+    if (!isNaN(+priceImpact)) return `≈${formatNumber(priceImpact, { style: 'percent', maximumSignificantDigits: 4 })}`
     return ''
   }, [priceImpact])
 

diff --git a/apps/main/src/lend/lib/apiLending.ts b/apps/main/src/lend/lib/apiLending.ts
@@ -2100,8 +2100,12 @@ function _getPriceImpactResp(priceImpactResp: PromiseSettledResult<string | unde
 
   if (resp.priceImpact === 'N/A') return resp
 
-  if (+resp.priceImpact > 0 && +slippage > 0) {
-    resp.isHighPriceImpact = +resp.priceImpact > +slippage
+  // Convert both values to numbers and get absolute value of price impact
+  const priceImpactNum = Math.abs(+resp.priceImpact)
+  const slippageNum = +slippage
+
+  if (slippageNum > 0) {
+    resp.isHighPriceImpact = priceImpactNum > slippageNum
   }
   return resp
 }