feat: add prices api #630
Merged
feat: add prices api #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlunara
force-pushed
the
feat/prices-api
branch
from
2c3cfe9 to
ad5f22e
Compare
DanielSchiavini
requested changes
Jan 27, 2025
Co-authored-by: Daniel Schiavini <daniel.schiavini@gmail.com>
…UTC if no time zone info is given
0xAlunara
force-pushed
the
feat/prices-api
branch
from
d148056 to
7ffaa22
Compare
OnlyJousting
approved these changes
Jan 27, 2025
DanielSchiavini
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily refactored on the Curve Monitor repo to make it as suitable as possible for curve.fi repo.
Package isn't ready for public publishing to the npm registry yet, internal usage is more important in the short term.
It doesn't have to be perfect from the start, we can add and modify params and typing as we use it over time.
I have split the actual refactoring that makes use of this package up into multiple smaller PRs which makes testing and reviewing easier. In those same PRs I will also modify the package code such that suits our needs (think of stuff like function parameters and such).
As such, this PR only adds code without using it yet.