Skip to content

Commit

Permalink
🐛 Fix the doubled-up help text in the raindrops details panel
Browse files Browse the repository at this point in the history
The help was doubled up in the tags widget as well as in the panel itself;
this had originally been done to make things work fine with Textual's own
help panel. However, when I realised it wasn't a good approach to showing
help for keyboard users I switched to my own help dialog, but forgot to undo
this workaround.

Fixes #39
  • Loading branch information
davep committed Jan 6, 2025
1 parent 8ba75cd commit 6d4ea04
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
7 changes: 7 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Braindrop ChangeLog

## Unreleased

**Released: WiP**

- Fixed doubling-up of the raindrop details panel's help when the raindrop's
tags have focus. ([#39](https://github.com/davep/braindrop/issues/39))

## v0.2.0

**Released: 2025-01-05**
Expand Down
17 changes: 6 additions & 11 deletions src/braindrop/app/widgets/raindrop_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,11 @@
from ..messages import ShowTagged
from .extended_option_list import OptionListEx

##############################################################################
HELP = """
## The highlighted Raindrop's details.
This panel contains the details of the currently-highlighted Raindrop.
"""
"""The help to use in the widgets."""


##############################################################################
class Tags(OptionListEx):
"""Show the tags for a Raindrop."""

HELP = HELP

_ICON: Final[str] = Emoji.replace(":bookmark: ")
"""The icon to show before tags."""

Expand Down Expand Up @@ -178,7 +168,12 @@ class RaindropDetails(VerticalScroll):
}
"""

HELP = HELP
HELP = """
## The highlighted Raindrop's details
This panel contains the details of the currently-highlighted Raindrop.
"""
"""The help to use in the widgets."""

BINDINGS = [
Binding(
Expand Down

0 comments on commit 6d4ea04

Please sign in to comment.