Tidy up everything to do with messages, commands and command providers #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some messages that are system-wide but which don't really have a command (in the command palette and key binding sense), so rather have them typed as a Command but with no other information added, fall back to doing them just as a Message.
What was the commands directory becomes the providers directory (the providers of commands for the command palette). What was (mostly) the messages directory gets turned into the commands directory; this is now where command messages are defined. Those messages that aren't "command messages" remain where they were.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move around and tidy up the code relating to messages, command messages and command palette providers. This PR doesn't make any significant changes to how this code works, it just breaks things down a little to help make it easier to navigate and maintain, and also improves the naming somewhat.