Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the collection count for groups #78

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Fix the collection count for groups #78

merged 1 commit into from
Jan 11, 2025

Conversation

davep
Copy link
Owner

@davep davep commented Jan 11, 2025

Each group header was showing the total count of collections rather than the count of collections within that group.

Fixes #77.

@davep davep added the Bug Something isn't working label Jan 11, 2025
@davep davep self-assigned this Jan 11, 2025
@davep davep merged commit fb96cdd into main Jan 11, 2025
4 checks passed
@davep davep deleted the fix-group-counts branch January 11, 2025 10:04
@davep davep mentioned this pull request Jan 11, 2025
Closed
davep added a commit that referenced this pull request Jan 11, 2025
@davep
🐛 Fix the count of collections within a group
3a5edc1 
Whereas #78 fixed the over-counting of collections within a group, this
fixes the under-counting of them when the collections within a group is a
hierarchy (the API only returns the top-level collections for the group).

Fixes #86.
@davep davep mentioned this pull request Jan 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davep davep

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numbers next to the collections are showing same number
1 participant
@davep