Improve strict schema string match with smarter matching #621
+134
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyl-db
force-pushed
the
tolerate-schema-subset
branch
2 times, most recently
from
bb68ecb to
ef53c76
Compare
linzhou-db
reviewed
Jan 7, 2025
client/src/main/scala/io/delta/sharing/spark/RemoteDeltaLog.scala
Outdated
Show resolved
Hide resolved
client/src/main/scala/io/delta/sharing/spark/RemoteDeltaLog.scala
Outdated
Show resolved
Hide resolved
andyl-db
force-pushed
the
tolerate-schema-subset
branch
2 times, most recently
from
781b9c3 to
0384302
Compare
andyl-db
force-pushed
the
tolerate-schema-subset
branch
from
0384302 to
047c1e6
Compare
linzhou-db
reviewed
Jan 24, 2025
| throw new SparkException( | ||
| s"""The schema or partition columns of your Delta table has changed since your | ||
| |DataFrame was created. Please redefine your DataFrame""") | ||
| val newSchema = DataType.fromJson(newMetadata.schemaString).asInstanceOf[StructType] |
There was a problem hiding this comment.
So we are using org.apache.spark.sql.types.DataType instead of a delta class (where we discussed to use a class reflection) to perform the comparison, is that good enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the strict schema string match with smarter matching i.e. subset matching
Added unit test
Tested against DBR:
