Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Correctly obtain domain when tld substring is in it #3

Merged
merged 3 commits into from
Feb 29, 2024
Merged

[2.x] Correctly obtain domain when tld substring is in it #3

merged 3 commits into from
Feb 29, 2024

Conversation

rickycheers
Copy link
Collaborator

No description provided.

@adrorocker adrorocker self-requested a review February 29, 2024 18:19
@adrorocker adrorocker changed the base branch from main to 2.x February 29, 2024 18:41
@adrorocker adrorocker changed the title Correctly obtain domain when tld substring is in it [2.x] Correctly obtain domain when tld substring is in it Feb 29, 2024
adrorocker
adrorocker approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@adrorocker adrorocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickycheers LGTM

Thanks for the contribution.

@adrorocker adrorocker merged commit 4687932 into domainvalidity:2.x Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrorocker adrorocker adrorocker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycheers @adrorocker