-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] [wasm] Make response streaming opt-out #111680
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this in principle. I'm concerned about how the breaking change will surface to people upgrading. My assumption is that it at the moment it will only show up at runtime?
Yes, it will only show up at runtime. Similar to Kestrels Could we add an app context switch to toggle this globally? |
} | ||
|
||
responseMessage.Content = streamingResponseEnabled | ||
responseMessage.Content = (_request.Options.TryGetValue(EnableStreamingResponse, out var streamingResponseEnabled) ? streamingResponseEnabled : true) && BrowserHttpInterop.SupportsStreamingResponse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all browsers support response streaming, should we remove BrowserHttpInterop.SupportsStreamingResponse
?
Tagging subscribers to 'arch-wasm': @lewing |
Enabling response streaming is a breaking change because sync reads are no longer allowed and throw
NotSupportedException
s.All supported browsers support response streaming.
To disable response streaming (and allow sync reads) set
WebAssemblyEnableStreamingResponse
tofalse
:Part of #77904