Always percent-escape semicolon in structured query encoding.

Fixes mirage/ocaml-cohttp#126. Fixes mirage#42. Creates mirage#43.
dsheets · Apr 28, 2014 · f107304 · f107304 · avsm · Apr 28, 2014
1 parent 777aa38
commit f107304
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/uri.ml b/lib/uri.ml
@@ -104,6 +104,7 @@ module Generic : Scheme = struct
     (* '&' is safe but we should encode literals to avoid ambiguity
        with the already parsed qs params *)
     a.(Char.code '&') <- false;
+    a.(Char.code ';') <- false;
     a.(Char.code '+') <- false;
     a
 

diff --git a/lib_test/test_runner.ml b/lib_test/test_runner.ml
@@ -135,6 +135,8 @@ let uri_query_make = [
   ["foo1",["bar1"];"foo2",["bar2"]], "foo1=bar1&foo2=bar2";
   ["foo1",["bar1"];"foo2",["bar2"];"foo3",["bar3"]],
   "foo1=bar1&foo2=bar2&foo3=bar3";
+  ["semicolon",[";"]],"semicolon=%3B";
+  [";",["semicolon"]],"%3B=semicolon";
   ["#",["#";"#"]], "%23=%23,%23";
   ["",[]], "";
   ["",[""]], "=";