Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change serde implementations #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change serde implementations #146

wants to merge 1 commit into from
+403 −495

Conversation

d-sonuga
Copy link

For #145.

@d-sonuga d-sonuga requested a review from Neotamandua January 22, 2025 12:08
@herr-seppia
Copy link
Member

How this PR impacts the serialization for blsPublicKey?

Keep in mind we need the serialization as bs58 string for that struct

@d-sonuga
Copy link
Author

@herr-seppia, this PR doesn't impact the serialization of the bls PublicKey. Bls PublicKey serializes its bytes representation directly (https://github.com/dusk-network/bls12_381-bls/blob/b9526c25f1841223c6bd261a90c108bff8875dc0/src/serde_support.rs#L21).

Neotamandua
Neotamandua approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM to me. I have two nits that are not critical but we can resolve them before merging

src/fp2/dusk.rs Outdated Show resolved Hide resolved
src/fp2/dusk.rs Show resolved Hide resolved
@d-sonuga d-sonuga force-pushed the change-serde-impl branch 2 times, most recently from 4f08cb7 to cfcbc7c Compare January 23, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neotamandua Neotamandua Neotamandua approved these changes

@miloszm miloszm Awaiting requested review from miloszm

@moCello moCello Awaiting requested review from moCello

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-sonuga @herr-seppia @Neotamandua