Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scummtr): Work around script bug in 07.LFL in MANIAC-V2-EN #13

Closed
wants to merge 1 commit into from
Closed

fix(scummtr): Work around script bug in 07.LFL in MANIAC-V2-EN #13

wants to merge 1 commit into from

Conversation

dwatteau
Copy link
Owner

Some versions of MANIAC-V2-EN miss a byte in the opcode sequence for
printEgo, causing a fatal error while trying to export the subtitles.

See #12.

@dwatteau
fix(scummtr): Work around script bug in 07.LFL in MANIAC-V2-EN
8ae362e 
Some versions of MANIAC-V2-EN miss a byte in the opcode sequence for
printEgo, causing a fatal error while trying to export the subtitles.

See #12.
@dwatteau dwatteau mentioned this pull request Dec 24, 2020
Open
@dwatteau
Copy link
Owner Author

Well, this patch is a bit naive in the way it deals with _file->name() and _file->fullOffset(), but the real problem is that it won't work when you import back the translation.

Same thing happens when I try to fix LFv2_0007/SCv2_0059 by hand. There's more than a missing byte and a single jump to fix, it seems…

@dwatteau dwatteau closed this Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dwatteau