Skip to content

Commit

Permalink
Tweak so_reuseport_aware validation
Browse files Browse the repository at this point in the history
  • Loading branch information
dzbarsky committed Aug 4, 2024
1 parent 9c73582 commit 314181a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion private/itest.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def _itest_service_impl(ctx):
if ctx.attr.health_check_timeout:
_validate_duration("health_check_timeout", ctx.attr.health_check_timeout)

if ctx.attr.so_reuseport_aware and not ctx.attr.autoassign_port:
if ctx.attr.so_reuseport_aware and not (ctx.attr.autoassign_port or ctx.attr.named_ports):
fail("SO_REUSEPORT awareness only makes sense when using port autoassignment")

extra_service_spec_kwargs = {
Expand Down

0 comments on commit 314181a

Please sign in to comment.