Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Change 1 - Two new config vars: cognito.endpoint & cognito.scheme
This PR wishes to add two new config variables called:
'endpoint' => config('cognito.endpoint'),
'scheme' => config('cognito.scheme')
The reason for this requested change is that we wish to unit test without having to use a live AWS cognito pool, instead we are able to use a local docker container that mocks AWS cognito pool however it'll require changing the endpoint.
This change does not break backwards compatability.
Requested Change 2 - Refactor of refreshToken
It seems that the refreshToken trait relies on fetching the user via a access token being set in the Auth header or session, however an accessToken can be expired but a refreshToken still valid.
Instead this refactor allows the passing in of a $user model to fetch the sub Id, it will default back to the original way if not set.
In addition the refreshToken wasn't being invalidated after being used, the token is now invalidated.