Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest anyio #101

Merged
merged 14 commits into from
Aug 24, 2021
Merged

pytest anyio #101

merged 14 commits into from
Aug 24, 2021

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Aug 20, 2021 •
edited
Loading

Add pytest anyio

graingert
graingert requested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to use @pytest.mark.anyio

@aminalaee
Copy link
Member Author

aminalaee commented Aug 20, 2021 •
edited
Loading

@graingert Thanks. But anyio is not required in orm. Do you mean we add that too?

@graingert
Copy link
Member

afaik, orm and databases are designed with Starlette in mind and so should also work with anyio eventually

@aminalaee aminalaee requested a review from graingert August 20, 2021 10:10
@aminalaee aminalaee changed the title pytest-asyncio pytest-anyio Aug 24, 2021
graingert
graingert requested changes Aug 24, 2021
View reviewed changes
Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyio is only a test dep for now

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
aminalaee and others added 2 commits August 24, 2021 15:58
@aminalaee @graingert
Update setup.py
d8eef31 
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@aminalaee
add anyio to test requirements.txt
89839b4
@aminalaee aminalaee requested a review from graingert August 24, 2021 11:46
@aminalaee aminalaee changed the title pytest-anyio pytest anyio Aug 24, 2021
@aminalaee aminalaee merged commit ec54759 into encode:master Aug 24, 2021
@aminalaee aminalaee deleted the pytest-asyncio branch August 24, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert Awaiting requested review from graingert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @graingert