Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTEMS allows blocking sockets to be interrupted by
shutdown()
(aka.esscimqi_socketBothShutdownRequired
). However, a concurrentclose()
is a race which can leave asend()
/recv()
call permanently stuck! The right way to handle this (aside from fixing the stack) would be to sequenceshutdown()
->exitWait()
->epicsSocketDestroy()
. This is hard to handle since this must be done for both sender and receiver thread, which presents difficulties owing to how theTransport
hierarchy is structured sinceTransport::close()
can happen on either worker, or a user thread.Rather than try to straighten this mess out properly, we add this "wait" in-between
shutdown()
andepicsSocketDestroy()
to hopefully wait for the workers (or other worker) to return fromsend()
/recv()
.cf. #150