Replace READONLY with const #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synApps R6-2-1 (the latest release as of 2023-11-30) includes sscan
R2-11-4 (not the latest release as of 2023-11-30), which fails to build
against EPICS Base 7.0.7 due to sscan's use of the READONLY macro:
----
../saveData_writeXDR.c:1841:2: error: use of undeclared identifier 'READONLY'
READONLY DBR_VAL * pval = eha.dbr;
^
----
Andrew Johnson suggests in
https://epics.anl.gov/tech-talk/2023/msg01849.php
that the READONLY macro was likely being defined as a side effect with
earlier versions of EPICS Base because most EPICS Base header files used
to include shareLib.h, which defines READONLY. In EPICS Base now,
though, Andrew says that the shareLib.h header file is no longer being
included by most of the EPICS Base header files, and so it's likely that
this is why sscan R2-11-4 no longer builds.
Andrew recommends replacing READONLY with const now that all the
compilers supported by EPICS Base support the const keyword, so do just
that.
Lastly, this particular build failure was likely fixed in commit
420274c
which adds a shareLib.h include to saveData_writeXDR.c. However, it
didn't add an include to saveData.c, so that file is likely still ending
up with READONLY defined as a side effect. Given this and Andrew's
comments, it's better to replace READONLY with const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synApps R6-2-1 (the latest release as of 2023-11-30) includes sscan R2-11-4 (not the latest release as of 2023-11-30), which fails to build against EPICS Base 7.0.7 due to sscan's use of the READONLY macro:
Andrew Johnson suggests in
https://epics.anl.gov/tech-talk/2023/msg01849.php
that the READONLY macro was likely being defined as a side effect with earlier versions of EPICS Base because most EPICS Base header files used to include shareLib.h, which defines READONLY. In EPICS Base now, though, Andrew says that the shareLib.h header file is no longer being included by most of the EPICS Base header files, and so it's likely that this is why sscan R2-11-4 no longer builds.
Andrew recommends replacing READONLY with const now that all the compilers supported by EPICS Base support the const keyword, so do just that.
Lastly, this particular build failure was likely fixed in commit
420274c
which adds a shareLib.h include to saveData_writeXDR.c. However, it didn't add an include to saveData.c, so that file is likely still ending up with READONLY defined as a side effect. Given this and Andrew's comments, it's better to replace READONLY with const.