-
Notifications
You must be signed in to change notification settings - Fork 39
Changed Header and payload to current API #9
Conversation
…ect, add them not shared if needed
Please separate each commit to different PRs. Also, the keys are for APNs and DeviceCheck. Please add another file for App Store Connect API instead. |
Close the PR because you should separate each commit to different PRs. |
@ethanhuang13 closing a pr because each commit needs to be a PR is not really a reason. Also what I did actually works and is needed. So I will look into it but I tried to help you. Why the defence? |
Thanks for this comment but. I will change this in issue #10 |
"fix signing"(4bd3669) is not a fix, you've just change to what you need(manual) and its not related to App Store Connect API. These three commits 3c49575, 99728e1, and 9f09752 have the same situation. If you separate them as different PRs, I can accept them. |
@ethanhuang13 I have read your ReadMe and also the link to the article related to the commits. Interesting point of view. I will read it and make it better. Just I thought this was already a small PR. Also I made a mistake in thinking your frameworks was only for App Store Connect. It is not so I will change that. So I was a bit quick in asking why you rejected, sorry. |
I guess it was different before. Added some keys and now it works for me at least.