#469 enum p21

eventhorizonpl · Jan 28, 2022 · 3b65f9b · 3b65f9b
1 parent 9761504
commit 3b65f9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Service/RewardService.php b/src/Service/RewardService.php
@@ -17,12 +17,12 @@ public function __construct(
     ) {
     }
 
-    public function findReward(Routine $routine, string $type): ?Reward
+    public function findReward(Routine $routine, RewardTypeEnum $type): ?Reward
     {
         $user = $routine->getUser();
         $types = [
-            RewardTypeEnum::ALL,
-            $type,
+            RewardTypeEnum::ALL->value,
+            $type->value,
         ];
         $reward = $this->rewardRepository->findOneByUserAndTypesAndRoutine($user, $types, $routine);
 
@@ -33,7 +33,7 @@ public function findReward(Routine $routine, string $type): ?Reward
         return $reward;
     }
 
-    public function manageReward(Routine $routine, string $type): ?Reward
+    public function manageReward(Routine $routine, RewardTypeEnum $type): ?Reward
     {
         $reward = $this->findReward($routine, $type);
 

diff --git a/src/Service/SavedEmailService.php b/src/Service/SavedEmailService.php
@@ -5,6 +5,7 @@
 namespace App\Service;
 
 use App\Entity\{SavedEmail, User};
+use App\Enum\SavedEmailTypeEnum;
 use App\Factory\SavedEmailFactory;
 use App\Manager\SavedEmailManager;
 
@@ -18,7 +19,7 @@ public function __construct(
 
     public function create(
         string $email,
-        string $type,
+        SavedEmailTypeEnum $type,
         User $user
     ): SavedEmail {
         $savedEmail = $this->savedEmailFactory->createSavedEmailWithRequired(