address failing document_spec #518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccrorie
changed the title
duncdrum
force-pushed
the
knock-knock-ci
branch
from
59ec413 to
e35aef7
Compare
|
something is still not right, nothing gets rendered on CI, whereas this is what electron headless looks on my system. |
duncdrum
force-pushed
the
knock-knock-ci
branch
from
9d9523b to
f046fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renaming documents is broken beyond testsuite fixes. We should not let the green in this one blind us that create, save, delete and renaming documents is bugged. The testsuite as is after this is merged, runs what can be run, and contains inlined functions and comments about what should be run, and why it currently can't. These all need to be addressed one way or the other, not by hacking away at the testsuite, but by code fixes.
close #400
see #412 - #414, #424, #430, #433, #513, #516 - #527