Added newtype support for primitive type enum #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
michalgr
requested changes
Nov 14, 2023
michalgr
reviewed
Nov 17, 2023
michalgr
reviewed
Nov 18, 2023
michalgr
reviewed
Nov 21, 2023
Daquiver1
added a commit
to Daquiver1/ExtendedAndroidTools
that referenced
this pull request
Nov 21, 2023
* Added newtype support for primitive type enum * Make newgen generator automatic * Changed type of jdwp_type and changed default type to int * Wrote test to validate primitive type mapping * Added test for type alias definition * Factored out function defining type alias. * Used absolute name format for newtype * Changed testing framework to unittest * Added dependency for jdwp project * Added int and string type * Changed the expected start * Updated test and removed int and byte from primitive types. * Removed int and boolean type from new type generator * doc: add copyright
Daquiver1
added a commit
to Daquiver1/ExtendedAndroidTools
that referenced
this pull request
Nov 23, 2023
* Added newtype support for primitive type enum * Make newgen generator automatic * Changed type of jdwp_type and changed default type to int * Wrote test to validate primitive type mapping * Added test for type alias definition * Factored out function defining type alias. * Used absolute name format for newtype * Changed testing framework to unittest * Added dependency for jdwp project * Added int and string type * Changed the expected start * Updated test and removed int and byte from primitive types. * Removed int and boolean type from new type generator * doc: add copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.