Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jdwp description importable #87

Merged

Conversation

michalgr
Copy link
Contributor

No description provided.

schema.py type-checks, but raises exception at runtime because Struct is
referenced before it is defined. This commit
- moves definition of Type to the top
- uses string names for forward type references
- replaces T with covariant TypeT
- fixes missing type parameter in Struct definition
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2023
@michalgr michalgr merged commit 9c28279 into facebookexperimental:main Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants