bundle: add support for retrieving bundles from a block engine #3036
+3,435
−380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcgee-jump
force-pushed
the
mmcgee/bundle1
branch
2 times, most recently
from
7e3ac49 to
8166f39
Compare
mmcgee-jump
force-pushed
the
mmcgee/bundle1
branch
from
8166f39 to
485d694
Compare
mmcgee-jump
force-pushed
the
mmcgee/bundle1
branch
20 times, most recently
from
4dde92b to
8da2570
Compare
two-heart
requested changes
Jan 16, 2025
| // achieve that. I wrote a custom futures executor to do this, | ||
| // but unfortuantely the libraries require Tokio to use some of | ||
| // the I/O functionality and will error without a Tokio Runtime. | ||
| cx.waker().clone().wake(); |
There was a problem hiding this comment.
Can we use cx.waker().wake_by_ref() here to not clone
two-heart
reviewed
Jan 16, 2025
ptaffet-jump
force-pushed
the
mmcgee/bundle1
branch
3 times, most recently
from
09f1857 to
f7dfccd
Compare
ptaffet-jump
force-pushed
the
mmcgee/bundle1
branch
3 times, most recently
from
856192a to
bcbd76b
Compare
ptaffet-jump
force-pushed
the
mmcgee/bundle1
branch
from
bcbd76b to
3030cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.