Netlink tile #4049
Netlink tile #4049
Conversation
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
from
ebeee1a to
1e5f22d
Compare
ripatel-fd
requested review from
mmcgee-jump,
nbridge-jump,
akhinvasara-jumptrading and
ptaffet-jump
| # the additional addresses can be specified here, and packets | ||
| # addressed to them will be accepted. | ||
| multihome_ip_addrs = [] | ||
| # The netlink tile forwards Linux network configuration to net tiles. |
There was a problem hiding this comment.
These docs are operator facing so please expand a little bit, and explain things in language for operators not developers. At least a paragraph describing the tile, e.g. see net above.
| multihome_ip_addrs = [] | ||
| # The netlink tile forwards Linux network configuration to net tiles. | ||
| [tiles.netlink] | ||
| # The maximum number of routes per route table. |
There was a problem hiding this comment.
Per above, lengthen docs, e.g. describe why you might need to increase this, what's a route table, ..
There was a problem hiding this comment.
I'd probably note that these are advanced configuration and don't need to be changed except for unique / custom networking configurations?
src/app/fdctl/config/default.toml
Outdated
| # See `ip route show table all` | ||
| max_routes = 128 | ||
|
|
||
| # The maximum number of Ethernet neighbors (aka ARP table entries). |
There was a problem hiding this comment.
Would simplify this summary a little bit, for operators that might not know what ARP is, but have decent networking knowledge, with a bit more detail below.
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
2 times, most recently
from
c7e6369 to
73f65cd
Compare
|
@mmcgee-jump Thanks for the review. I addressed all the code concerns. I'll need some help with documentation for the config. I suggest we update the default config file later? |
| If fib is not in ACTIVE state, retval->rtype is set to | ||
| FD_FIB4_RTYPE_BLACKHOLE. | ||
|
|
||
| Thread safe; Gracefully handles concurrent route updates by other |
There was a problem hiding this comment.
Just double checking it's indeed supposed to say updates, rather than lookups?
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
2 times, most recently
from
4b02d01 to
ef2189f
Compare
Adds a simple pure FIB implementation compatible with Linux
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
from
ef2189f to
4bfee16
Compare
Relates to #692
Closes #3619