Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

x11-drivers/nvidia-{drivers, metadata}: Bump to 525.85.12 #2480

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sayanchowdhury
Copy link
Contributor

@sayanchowdhury sayanchowdhury commented Feb 23, 2023

x11-drivers/nvidia-{drivers, metadata}: Bump to 525.85.12

Testing done

CI Running http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1365/cldsv/

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@pothos
Copy link
Contributor

pothos commented Feb 23, 2023

The service also needs to go from coreos-base/oem-(azure|ec2-compat)/files/base/base(-ec2).ign

@sayanchowdhury sayanchowdhury force-pushed the sayan/update-nvidia-525.85.12 branch 2 times, most recently from ea363a6 to 3696e11 Compare February 28, 2023 16:08
@sayanchowdhury
Copy link
Contributor Author

@sayanchowdhury sayanchowdhury marked this pull request as ready for review March 1, 2023 09:10
@sayanchowdhury sayanchowdhury requested a review from a team March 1, 2023 09:11
@sayanchowdhury
Copy link
Contributor Author

The EM tests are rerunning because of flaky failures, but other archs looks good so marked ready for review.

@pothos
Copy link
Contributor

pothos commented Mar 1, 2023

Should we also have a migration path to bring the new version to old instances? (link to post action in old discussion: #2160 (comment))

@pothos
Copy link
Contributor

pothos commented Mar 1, 2023

Maybe the GCE test failed because of the long version or the second semver at the end? I've also noticed this here in the security changelog:

- intel-microcode ([CVE-2022-21216](https://nvd.nist.gov/vuln/detail/CVE-2022-21216), [CVE-2022-33196](https://nvd.nist.gov/vuln/detail/CVE-2022-33196), [CVE-2022-38090](https://nvd.nist.gov/vuln/detail/CVE-2022-38090))
 b0VIM 8.2�-��c�3xR��sayantatooine~sayan/code/work/scripts/sdk_container/src/third_party/portage-stable/changelog/security/2023-02-22-intel-microcode-20230214_p20230212.mdutf-8
U3210#"! ��Utp������ad����������- intel-microcode- less ([CVE-2022-46663](https://nvd.nist.gov/vuln/detail/CVE-2022-46663))

@pothos
Copy link
Contributor

pothos commented Mar 1, 2023

Ah, you commited changelog/security/.2023-02-22-intel-microcode-20230214_p20230212.md.swp in portage-stable

PR to remove: flatcar-archive/portage-stable#425

@pothos
Copy link
Contributor

pothos commented Mar 1, 2023

Adding a kola test is possible, the same way we run the cl.internet test on certain cloud instance types, but for now I think it would be enough to have it at least tested manually and report the results there.

@sayanchowdhury sayanchowdhury force-pushed the sayan/update-nvidia-525.85.12 branch from 3696e11 to f523ff2 Compare March 16, 2023 07:37
@@ -16,13 +16,12 @@ IUSE=""
S="${WORKDIR}"

RDEPEND="
=x11-drivers/nvidia-metadata-${PV}
=x11-drivers/nvidia-metadata-${PV}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move the contents of nvidia-metadata ebuild into this nvidia-drivers ebuild here to have all at one place now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's only focus on this here and then merge? Assuming that the driver still works.

@pothos
Copy link
Contributor

pothos commented Mar 16, 2023

Should we also have a migration path to bring the new version to old instances? (link to post action in old discussion: #2160 (comment))

For the migration to take place the files we need to remove are /etc/systemd/system/nvidia.service /usr/share/oem/bin/setup-nvidia /usr/share/oem/bin/install-nvidia /usr/share/oem/units/nvidia.service. Since #2506 is also in progress and will have migration logic, I suggest we don't do it here but remember to do it in that PR (goes to bootengine dracut/99setup-root/initrd-setup-root-after-ignition).

@sayanchowdhury sayanchowdhury force-pushed the sayan/update-nvidia-525.85.12 branch from f523ff2 to e3abbb2 Compare March 16, 2023 12:03
@sayanchowdhury
Copy link
Contributor Author

s also in pr

Yes, Rightly pointed. I'm just testing out if the the postinst logic works. Marking this PR as WIP.

@sayanchowdhury sayanchowdhury marked this pull request as draft March 16, 2023 12:12
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants