freckle-stats, freckle-ecs #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits outs two packages.
The statsd stuff is used by anything in production that does SQL queries to report its connection pool usage, and so this is one prerequisite for getting e.g.
curricula-apioff of thefreckle-appmonolith dependency.The ECS package is also pulled out at this time because
freckle-statsneeds it.Fixes release action (stack config filename hadn't been updated)
Breaking change: A trivial Yesod/StatsD integration
instance HasStatsClient site => HasStatsClient (HandlerData child site)has been removed and will need to be copied into individual applications.