packagelists: don't remove ppp-related packages #36
Conversation
|
If u have the time, it is always nice to know how much diskspace this costs. ;) |
|
On my GL-AR150 this took around 300kb. |
|
@Akira25 why is wpad-mini also included in this PR? I feel like it is unrelated. If it is somehow necessary, please either remove wpad-mini in a seperate commit or as a totally different PR. |
|
Also, please change the commit comment. pppoe is not only used for DSL, but in other transport layers as well. It would be best just to use pppoe and not mention DSL at all. :) |
|
I assumed, that |
Akira25
force-pushed
the
fix/dsl-packages
branch
from
3cb3389 to
68ca904
Compare
|
@pmelange I changed commit that to meet your suggestions. :) |
|
@pmelange sven wrote something on |
|
I guess it would need to be added, but the best way is to test. :) |
|
@Akira25 Let me know if adding luci-proto-ppp is not needed so that I can merge this. |
The removal of ppp-packages was presumeably introduced 2014 to save space on 4MB-Devices. As Falter does not care for those, we readd them. Especially devices with built-in modem will profit from this. Have a look at: freifunk-berlin/falter-packages#92 (comment)
Akira25
force-pushed
the
fix/dsl-packages
branch
from
68ca904 to
c5265bb
Compare
|
@pmelange I tested on one of Matthias Fritzboxes. We can use the ppp-packages only in luci, if we install that proto-package. It does not depend on anything except libc, so it shouldn't be a big deal. This can be merged now. |
The removal of dsl-related packages was presumeably introduced
2014 to save space on 4MB-Devices. As Falter does not care for
those, we may readd them.
Have a look at: freifunk-berlin/falter-packages#92 (comment)
Before merging this, we should have some further discussion on the
standard WAN-Interface (on DSL-Modem or LAN1)