Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(structure): merge infer dir into rvc for move uniform API access #21

Closed
wants to merge 1 commit into from

Conversation

alexlnkp
Copy link
Contributor

@alexlnkp alexlnkp commented Jun 9, 2024

this also moves train from infer.lib to rvc.lib which just makes more sense than having train under infer

might be too extreme of a change for now, but hopefully not, since this tidies up the structure quite drastically

…cess to the API

this also moves `train` from `infer.lib` to `rvc.lib` which just makes more sense than having `train` under `infer`
@alexlnkp
Copy link
Contributor Author

alexlnkp commented Jun 9, 2024

i guess i could preserve the split of train and infer by making dirs that contain scripts that either one needs, not sure if this would be necessary though... but i'm up to making changes!

@fumiama
Copy link
Owner

fumiama commented Jun 9, 2024

Well, don't be so hurry 😂. I'm moving the infer to rvc gradually, by viewing the codes line by line and place them into the proper position to modularize it. Now, just keep the half-infer half-rvc status and the infer part will decrease, the rvc part will increase.

@alexlnkp
Copy link
Contributor Author

alexlnkp commented Jun 9, 2024

Yeah, sorry, I'm quite hasty when it comes to making some changes which I planned to do for months 😅
I thought it'd be easier to first move things in their new places and then start making changes about how these things are used, but I guess that is not always the case...
Should i close this PR?

@fumiama
Copy link
Owner

fumiama commented Jun 9, 2024

I thought it'd be easier to first move things in their new places and then start making changes about how these things are used

Move many stuffs at the same time will make it easier to ignore some codes refer to it.

Should i close this PR?

Yes, you should. But thanks to your passion. If you like, you can separate the uvr5_park part first, which will not be included in the rvc folder.

@alexlnkp
Copy link
Contributor Author

alexlnkp commented Jun 9, 2024

Alrighty then :)

@alexlnkp alexlnkp closed this Jun 9, 2024
@alexlnkp alexlnkp deleted the dev branch June 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants