-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation supress #38
Conversation
WalkthroughThe update introduces a new feature to the project by adding a target for running a Streamlit application in the Makefile. Additionally, it streamlines the Streamlit app by removing deprecated configuration related to file uploader encoding. This change enhances the user experience and maintains the codebase's adherence to best practices. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app: | ||
streamlit run app.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the app
target to run the Streamlit application is a useful enhancement for simplifying the development workflow. However, it's good practice to specify the full path to the app.py
file to avoid potential issues with running the command from different directories. If app.py
is located in the root directory and you expect the Makefile to be run from there, this is fine. Otherwise, consider specifying the full path.
- streamlit run app.py
+ streamlit run ./app.py
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
app: | |
streamlit run app.py | |
app: | |
streamlit run ./app.py |
Summary by CodeRabbit