Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script gets its OBR version dynamically, same as the galasa version. #174

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Jan 30, 2025

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

Why ?

I got worried that every time I was running the run-locally.sh script that it was launching using the wrong OBR version, as the OBR version was hard-coded into the script.

I changed the script to dig out the version from the build.gradle file, which will be the same as the OBR version now that everything uses the same versioning scheme.

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Copy link
Contributor

@aashir21 aashir21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@techcobweb techcobweb merged commit 4d652d0 into main Jan 30, 2025
29 checks passed
@techcobweb techcobweb deleted the mcobbett-uplift-version-script-fixes branch January 30, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants