Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence case #335

Merged
merged 4 commits into from
May 7, 2024
Merged

Sentence case #335

merged 4 commits into from
May 7, 2024

Conversation

ulm
Copy link
Member

@ulm ulm commented Apr 29, 2024

No description provided.

@ulm ulm requested review from maffblaster and thesamesam April 29, 2024 16:48
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some reservations wrt breaking links but after discussion on IRC, I'm happy. Thanks.

@ulm ulm force-pushed the sentence-case branch 2 times, most recently from 237fc3e to a9b0b8b Compare April 29, 2024 19:32
maffblaster and others added 4 commits May 7, 2024 19:16
Signed-off-by: Matthew Marchese <maffblaster@gentoo.org>
[Whitespace. Fix rebase artifact in ebuild-writing/functions/src_test.]
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
This is referred to as the "Clean patch howto" from several other
places. The wording change would also break links because the section
title is used as fragment identifier.

Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Internal links referring to sections were broken by the previous
"Sentence case devmanual" commit.

Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Apparently these have been missed previously.

Signed-off-by: Ulrich Müller <ulm@gentoo.org>
@ulm ulm force-pushed the sentence-case branch from a9b0b8b to fe83e87 Compare May 7, 2024 17:18
@gentoo-bot gentoo-bot merged commit fe83e87 into gentoo:master May 7, 2024
1 check passed
@maffblaster
Copy link
Contributor

Thank you for merging, @ulm!

@ulm ulm deleted the sentence-case branch May 8, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants