Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zap integration #958

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add zap integration #958

wants to merge 11 commits into from

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Jan 25, 2025

Resolves #340

TODO:

@ribice ribice requested a review from cleptric January 25, 2025 19:18
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 57.37052% with 107 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (f2d4348) to head (fede5d6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
zap/core.go 45.94% 65 Missing and 15 partials ⚠️
zap/sentryzap.go 63.82% 16 Missing and 1 partial ⚠️
zap/field.go 0.00% 4 Missing ⚠️
zap/frame_matcher.go 71.42% 4 Missing ⚠️
zap/util.go 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   83.61%   82.44%   -1.17%     
==========================================
  Files          49       54       +5     
  Lines        5133     5384     +251     
==========================================
+ Hits         4292     4439     +147     
- Misses        684      773      +89     
- Partials      157      172      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with zap logging library
2 participants