Remove Clone Staring Me In the Face #6969
Draft
+36
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
commented
Jan 21, 2025
| @@ -706,7 +706,7 @@ unsafe fn insert<T: Clone>( | |||
| *current_states.get_unchecked_mut(index) = new_end_state; | |||
|
|
|||
| let resource = metadata_provider.get(index); | |||
| resource_metadata.insert(index, resource.clone()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an unconditional clone when we merge trackers, even if the tracker already owns that resource. This clone has been staring me in the face. This was a quick experiment to see if it would help. According to our benchmarks, it doesn't. HOWEVER, the benchmarks never re-use textures between bind groups. There's a 1:1 relationship between a set of textures and a bind group. We also only ever bind a bind group once. This just... isn't terribly realistic. We need to modify our render benchmark to be more representative. That's more than the 10 minutes I had timeboxed for this experiment tho.
Also this PR is wrong wrt Weak handling.
Edit: ayy funny number