Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Only migrate found collections (GSI-1308) #88

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

TheByronHimes
Copy link
Member

This PR fixes an issue found in testing where uninitialized collections crashed the migration process (can't rename a collection that doesn't exist). The migration process previously assumed the collections would exist, but now it will check before staging/unstaging and do nothing if they don't exist. This will allow migration-equipped services to start up in test environments that might not have test data already created.

Of course, when testing the migrations specifically in those environments, we need to have test data present before starting the services. That's a team coordination thing though, imo and not an app/config problem.

@TheByronHimes TheByronHimes changed the title Only migrate found collections (GSI-1308) [patch] Only migrate found collections (GSI-1308) Jan 27, 2025
@TheByronHimes TheByronHimes merged commit 9360df6 into main Jan 27, 2025
17 checks passed
@TheByronHimes TheByronHimes deleted the feature/only_migrate_found_collections_GSI-1308 branch January 27, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants