Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase download timeout and improve error messages (GSI-537) #87

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Dec 14, 2023

This PR increases the timeout for the flaky request that involves S3 access on the backend.

It also recognizes more error classes as connection errors that produce more detailed error messages.

Both of these should be considered as hotfixes and eventually be solved more properly.

Copy link

github-actions bot commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7207286568

  • 9 of 10 (90.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ghga_connector/core/exceptions.py 0 1 0.0%
Totals Coverage Status
Change from base Build 6957786574: 0.02%
Covered Lines: 827
Relevant Lines: 1096

💛 - Coveralls

@Cito Cito requested a review from mephenor December 14, 2023 10:00
@Cito Cito merged commit 75e9acd into main Dec 14, 2023
7 checks passed
@Cito Cito deleted the feature/timeout-and-errors-GSI-537 branch December 14, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants