Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): Add Pub/Sub ingestion from Kafka samples #14954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Jan 23, 2025

Add samples and tests for Cloud Pub/Sub ingestion from Kafka.


This change is Reviewable

@michaelpri10 michaelpri10 requested a review from a team as a code owner January 23, 2025 21:53
@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jan 23, 2025
@michaelpri10
Copy link
Contributor Author

/gcbrun

@scotthart
Copy link
Member

/gcbrun

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @michaelpri10)


google/cloud/pubsub/samples/topic_admin_samples.cc line 283 at r1 (raw file):

  [](pubsub_admin::TopicAdminClient client, std::string project_id,
     std::string topic_id, std::string cluster_arn, std::string msk_topic,
     std::string aws_role_arn, std::string gcp_service_account) {

For these strings that are only used once, either std::move them when they are used or change the parameter type from std::string to std::string const&.

Here and elsewhere in the changes.

Copy link
Contributor Author

@michaelpri10 michaelpri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @scotthart)


google/cloud/pubsub/samples/topic_admin_samples.cc line 283 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

For these strings that are only used once, either std::move them when they are used or change the parameter type from std::string to std::string const&.

Here and elsewhere in the changes.

Done.

@scotthart
Copy link
Member

/gcbrun

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 30 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (8ea0d5e) to head (dd0475a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/pubsub/samples/topic_admin_samples.cc 70.58% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14954      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.02%     
==========================================
  Files        2351     2351              
  Lines      210083   210185     +102     
==========================================
+ Hits       195193   195266      +73     
- Misses      14890    14919      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants