-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pubsub): Add Pub/Sub ingestion from Kafka samples #14954
base: main
Are you sure you want to change the base?
Conversation
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @michaelpri10)
google/cloud/pubsub/samples/topic_admin_samples.cc
line 283 at r1 (raw file):
[](pubsub_admin::TopicAdminClient client, std::string project_id, std::string topic_id, std::string cluster_arn, std::string msk_topic, std::string aws_role_arn, std::string gcp_service_account) {
For these strings that are only used once, either std::move
them when they are used or change the parameter type from std::string
to std::string const&
.
Here and elsewhere in the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @scotthart)
google/cloud/pubsub/samples/topic_admin_samples.cc
line 283 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
For these strings that are only used once, either
std::move
them when they are used or change the parameter type fromstd::string
tostd::string const&
.Here and elsewhere in the changes.
Done.
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14954 +/- ##
==========================================
- Coverage 92.91% 92.90% -0.02%
==========================================
Files 2351 2351
Lines 210083 210185 +102
==========================================
+ Hits 195193 195266 +73
- Misses 14890 14919 +29 ☔ View full report in Codecov by Sentry. |
Add samples and tests for Cloud Pub/Sub ingestion from Kafka.
This change is