-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
crocochrome
branch
22 times, most recently
from
May 30, 2024 11:39
6bf073d
to
7507403
Compare
nadiamoe
force-pushed
the
crocochrome
branch
3 times, most recently
from
June 3, 2024 10:11
14c2a2e
to
4c93016
Compare
This is getting a tad out of hand. |
nadiamoe
force-pushed
the
crocochrome
branch
2 times, most recently
from
June 21, 2024 11:08
ad6dfd5
to
dd4b0f3
Compare
ka3de
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just made a few small comments. Feel free to disregard the nit ones if they do not match for you @roobre
nadiamoe
force-pushed
the
crocochrome
branch
9 times, most recently
from
July 9, 2024 11:18
52f3cd7
to
333c364
Compare
nadiamoe
force-pushed
the
crocochrome
branch
2 times, most recently
from
July 9, 2024 15:27
11a582c
to
e5faa0d
Compare
mem
approved these changes
Jul 9, 2024
ka3de
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of Crocochrome, following design at https://github.com/grafana/sm-k6-runner/issues/171