Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Initial implementation #1

merged 13 commits into from
Jul 10, 2024

Conversation

nadiamoe
Copy link
Member

Initial implementation of Crocochrome, following design at https://github.com/grafana/sm-k6-runner/issues/171

@nadiamoe nadiamoe force-pushed the crocochrome branch 22 times, most recently from 6bf073d to 7507403 Compare May 30, 2024 11:39
@nadiamoe nadiamoe requested a review from a team as a code owner May 31, 2024 13:21
@nadiamoe nadiamoe force-pushed the crocochrome branch 3 times, most recently from 14c2a2e to 4c93016 Compare June 3, 2024 10:11
@mem
Copy link
Contributor

mem commented Jun 20, 2024

This is getting a tad out of hand.

@nadiamoe nadiamoe force-pushed the crocochrome branch 2 times, most recently from ad6dfd5 to dd4b0f3 Compare June 21, 2024 11:08
Copy link

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just made a few small comments. Feel free to disregard the nit ones if they do not match for you @roobre

doc/chomium-sandbox.md Outdated Show resolved Hide resolved
doc/chomium-sandbox.md Outdated Show resolved Hide resolved
doc/chomium-sandbox.md Outdated Show resolved Hide resolved
doc/chomium-sandbox.md Outdated Show resolved Hide resolved
chromium/chromium.go Outdated Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
crocochrome.go Show resolved Hide resolved
crocochrome.go Outdated Show resolved Hide resolved
crocochrome.go Outdated Show resolved Hide resolved
crocochrome.go Show resolved Hide resolved
@nadiamoe nadiamoe force-pushed the crocochrome branch 9 times, most recently from 52f3cd7 to 333c364 Compare July 9, 2024 11:18
@nadiamoe nadiamoe requested a review from ka3de July 9, 2024 12:02
@nadiamoe nadiamoe mentioned this pull request Jul 9, 2024
1 task
@nadiamoe nadiamoe force-pushed the crocochrome branch 2 times, most recently from 11a582c to e5faa0d Compare July 9, 2024 15:27
@nadiamoe
Copy link
Member Author

Squashed fixup commits, huge thanks to @ka3de and @mem for giving this massive patchset a read!

@nadiamoe nadiamoe merged commit e0a14a2 into main Jul 10, 2024
4 checks passed
@nadiamoe nadiamoe deleted the crocochrome branch July 10, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants