Tag image with chromium version as build metadata

[nadiamoe]

Following consensus on https://docs.google.com/document/d/1ZbjNIrk-i3DYB1_jklr5Xx4hDc8Px4bP-zIK-TXYsCQ/edit

Implementation-wise, a small script extracts the chromium version from the apk add ... line in Dockerfile, which is then appended to the build tag.

Requires #5

[mem]

I had to go take a look at the dockerfile just to figure out why the regular expression is expecting "stuff" around it. Adding comments or changing the formatting of the line might end up breaking this.

I think you can make this more robust if you change the dockerfile.

Add:

ARG chromium_version=126.0.6478.126-r1

and

RUN apk --no-cache add --repository community tini=0.19.0-r3 && \
  apk --no-cache add --repository community chromium-swiftshader=$chromium_version

and then the script can anchor the regular expression correctly:

sed -nr 's/^ARG chromium_version=([0-9A-Za-z+._-]+)$/\1/p'

Also, why are you expecting + and _ to show up there? Even the letters are a bit questionable. But with this change I would be more open to this:

sed -nr 's/^ARG chromium_version=(.+)$/\1/p'

as that is saying "I'll take whatever is the value of this variable". You might want to trim end-of-line whitespace, just to be nice to puny humans....

[nadiamoe]

I went for matching the whole dockerfile because it's the same thing #5 does, I'd rather not duplicate it. #5 cannot (reliably) work with ARG ... because it needs to know the repository (main or community) where this is pulled from.

[nadiamoe]

Closing for now as Docker does not support + in tags.