Issue/504 use lower case name #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sabonchi
requested review from
konstantinschuette,
DasProffi and
felixevers
and removed request for
a team and
konstantinschuette
BrowserStackCommit: helpwave tasks
helpwave impulse
|
|
@florian-sabonchi was there a linter warning or what is the reasoning behind this pr? If thats a convention, please update our linter. |
yes there is a linter warning |
DasProffi
requested changes
Feb 19, 2024
Co-authored-by: Felix <67233923+DasProffi@users.noreply.github.com>
Co-authored-by: Felix <67233923+DasProffi@users.noreply.github.com>
DasProffi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues does this pull request close?
closes #504
[OPTIONAL] Give testing instructions to reviewers