Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow on Patient and Task BottomSheet #508

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

florian-sabonchi
Copy link
Contributor

Which issues does this pull request close?

closes #506

[OPTIONAL] Give testing instructions to reviewers

@florian-sabonchi florian-sabonchi requested a review from a team as a code owner March 9, 2024 18:00
@florian-sabonchi florian-sabonchi requested review from MaxSchaefer and DasProffi and removed request for a team March 9, 2024 18:00
Copy link

github-actions bot commented Mar 9, 2024

BrowserStack

Commit: 1012b1b

helpwave tasks

helpwave impulse

@DasProffi
Copy link
Member

What kind of overflow are you trying to fix? The overflow of the original issue does not occur and is not addressed here.

Please provide an example/condition where the overflow occurred before, to allow us to validate it.

@florian-sabonchi
Copy link
Contributor Author

What kind of overflow are you trying to fix? The overflow of the original issue does not occur and is not addressed here.

Please provide an example/condition where the overflow occurred before, to allow us to validate it.

If you go to Patient details and add a note you got an overflow

@DasProffi
Copy link
Member

Please open a new issue next time so that the purpose of the PR is clearly visible to the reviewers and outside observers

@DasProffi DasProffi changed the title fix: overflow fix overflow on Patient and Task BottomSheet Mar 9, 2024
@florian-sabonchi florian-sabonchi merged commit fb8dd9b into main Mar 10, 2024
6 checks passed
@florian-sabonchi florian-sabonchi deleted the issue/506-overflow-on-subtask-edit branch March 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow on subtask edit
2 participants