-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APR PR master v0p3p3 #82
Open
alexpreynolds
wants to merge
12
commits into
higlass:master
Choose a base branch
from
alexpreynolds:apr-PR-master-v0p3p3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S custom higlass-multivec)
pkerpedjiev
reviewed
Jan 22, 2025
@@ -231,6 +172,7 @@ const BasicMultipleLineChart = (HGC, ...args) => { | |||
} | |||
|
|||
getMouseOverHtml(trackX, trackY) { | |||
//console.log(this.tilesetInfo, trackX, trackY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete this
Any chance you could add a screenshot of the StackedDeltaBarChart? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for the HiGlass
higlass-multivec
track includes Pixi resource memory leak fixes, PNG/SVG export fixes, more graceful error handling for null Pixi objects, and feature enhancements for mouseover tooltips. This also includes a new track type calledhorizontal-stacked-delta-bar
, which looks similar to the UCSC Genome Browser graph tracks where data series can be layered atop one another (see "Overlay" section here: https://genome.ucsc.edu/goldenpath/help/hgWiggleTrackHelp.html). This also integrates fixes that have been merged into the upstream (base) repository in the master branch (currently post v0.3.3).