Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): include query params #3702

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Nov 25, 2024

The default value of built-in logger is not very desirable for API servers that use query params.
e.g.) https://hono-hacker-news.deno.dev/

It's a bit disruptive for logging, so we probably won't need to add it right away.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (76b7109) to head (5a8553b).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
- Coverage   91.70%   91.70%   -0.01%     
==========================================
  Files         159      159              
  Lines       10162    10161       -1     
  Branches     2981     2979       -2     
==========================================
- Hits         9319     9318       -1     
  Misses        842      842              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryuapp ryuapp changed the title feat(logger): include query param feat(logger): include query params Nov 26, 2024
@yusukebe yusukebe added the v4.7 label Jan 18, 2025
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @ryuapp

Sorry for the super late response. Looks good! Let's include this feature in the next minor version v4.7! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants