Fix array attributes #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declaration:
int arr[2] __attribute__((deprecated));
is currently parsed as:
int arr __attribute__((deprecated));
Ensure that ArrayDecl() layer is not lost when attaching attributes.
douglas-raillard-arm
force-pushed
the
fix_arr_attributes
branch
from
4d50f62 to
2c1c25c
Compare
inducer
reviewed
Sep 11, 2023
| assert isinstance(ast.ext[0].type, ArrayDecl) | ||
|
|
||
| from pycparserext.ext_c_generator import GnuCGenerator | ||
| print(GnuCGenerator().visit(ast)) |
There was a problem hiding this comment.
Would it be reasonable to assert that the round trip works?
|
@inducer Unfortunately I stopped using pycparserext (instead of parsing a pre-existing header made by another tool, I made a tool that creates the header in the first place) and I don't have the bandwidth to fix pycparserext. Feel free to re-own this PR if someone else wants to take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.