Fix: manage images with relative path in iframe #5
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelkurek
reviewed
Mar 1, 2024
Comment on lines
+125
to
+129
| // Keep only visible elements and delete source tags | ||
| children = children.filter( | ||
| (child) => child.style == null || child.style.display !== 'none', | ||
| (child) => | ||
| (child.style == null || child.style.display !== 'none') && | ||
| (child.tagName == null || child.tagName.toLowerCase() !== 'source'), |
There was a problem hiding this comment.
Why deleting source tags ? What will happen to a video with source tags ?
There was a problem hiding this comment.
The library relies on the video tag to generate the snapshot, not on the source tags. For the moment, I don't know why the source tag is causing a problem and preventing the image from displaying correctly.
| clonedNode.onload = resolve | ||
| clonedNode.onerror = reject | ||
| clonedNode.onerror = resolve |
There was a problem hiding this comment.
With the changes we've made, an error can occur ?
There was a problem hiding this comment.
I think so: image not found, CORS, ...
There was a problem hiding this comment.
It should be detected before with the fetchAsDataURL, done when requesting image. I don't think it can happens now with our changes in the player (the imagePlaceholder option set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the images with relative path in iframe.
Description
Images with relative path in iframe are not displayed because they do not contain the iframe domain.
Types of changes
Self Check before Merge