Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change settings panel behavior to slide instead of grow #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UnSeulT
Copy link
Contributor

@UnSeulT UnSeulT commented Sep 19, 2021

This fix the animation issue mentioned by @MisterDA in #109

Change line 991 is a no-brainer, no side effect.

About removing .profile rule line 51 : I can't see the use of fixing the width for .profile to 230px. It seems to be ok to remove this rule.
@jech
Copy link
Owner

jech commented Oct 30, 2021

I'm confused. Was that not fixed by 7aefb5e?

@UnSeulT
Copy link
Contributor Author

UnSeulT commented Nov 16, 2021

It was in a way :)
This solution is cleaner and more robust as you don't have to set the width for the panel in two different files : css and in js.
The js just add/remove a class to the element and all happen in the css.
And also, using css transform is a more efficient way to deal with css animation.

@spaetz
Copy link

spaetz commented Jun 1, 2023

I have tested the merge request on top of current 0.7.1 and can attest that opening and closing the settings sidebar works nicely on Firefox. Plus it is 11 lines of code less, so +1 for merging :)

@jech jech force-pushed the master branch 2 times, most recently from 65fa0be to 03038ea Compare January 11, 2024 21:05
@jech jech force-pushed the master branch 2 times, most recently from b7172df to 8de77fe Compare October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants