Update error message for GeneralHttpException to include the status code
#530
Conversation
… code. Updated the error message for the `GeneralHttpException` to include the status code, since I just observed a wild GHE thrown on a system outside my control and couldn't for the love of all computers find out which status code it had, even though I've tried to reproduce it and have since added GHE as an expected exception to handle in the retry policy in the app. Just wish I had the status code so I knew _why_ it threw on that one system outside my control, so here I am, adding it for any future devs in my previous position. Feel free to suggest another format if my suggested one is not accepted. Or just reject it outright, but if you do reject it, do please explain _why_ it's rejected.
| @@ -7,7 +7,7 @@ public class GeneralHttpException : TMDbException | |||
| public HttpStatusCode HttpStatusCode { get; } | |||
|
|
|||
| public GeneralHttpException(HttpStatusCode httpStatusCode) | |||
| : base("TMDb returned an unexpected HTTP error") | |||
| : base($"TMDb returned an unexpected HTTP error: {(int)httpStatusCode}") | |||
There was a problem hiding this comment.
Do we really need the explicit conversion to int?
There was a problem hiding this comment.
I did that to be on the safe side in case a status code returned from upstream is not part of the HttpStatusCode enum. If we don't cast to an int (or any other numerical type for that matter), then it will try to convert the value to the value's name when it stringifies it, but I don't and didn't remember how the runtime handles out of bounds values when stringifying, so for consistency's sake I would rather have it always print out the status code in it's numerical form. If you feel it's too much then we can drop the type cast.
An example of a status code not part of the enum (within is codebase even) is 429 (too many requests).
Updated the error message for the
GeneralHttpExceptionto include the status code, since I just observed a wild GHE thrown on a system outside my control and couldn't for the love of all computers find out which status code it had, even though I've tried to reproduce it and have since added GHE as an expected exception to handle in the retry policy in the app. Just wish I had the status code so I knew why it threw on that one system outside my control, so here I am, adding it for any future devs in my previous position. Feel free to suggest another format if my suggested one is not accepted. Or just reject it outright, but if you do reject it, do please explain why it's rejected.