Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved rebuild parameter page #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thxwelchs
Copy link

@thxwelchs thxwelchs commented Aug 19, 2024

The parameter value of parameter pages jelly resource can also find the parameter value's class, including its self class and superclasses.

In the Rebuild Jelly Resource, various plugin parameters that do not exist might be present, but most of them inherit from the upper-level Base parameter types. Therefore, it seems safer to have the default value of the upper parameter type applied when a Jelly fallback occurs.

This is particularly relevant when used with parameters like date-parameter plugin, where an incorrect value (such as the current date, LocalDate.now()) may be set as the default on the rebuild page.

Testing done

mvn clean verify passed

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The parameter value of parameter pages jelly resource can also find the parameter value's class, including its self class and superclasses.
@thxwelchs thxwelchs requested a review from a team as a code owner August 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant