Fix #2026 - Prevent logical<wide> to be constructed form non-bool single scalars #2052
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
force-pushed
the
fix/issue-2026/logical-ctor
branch
from
bcf275c to
e96299e
Compare
jfalcou
force-pushed
the
fix/issue-2026/logical-ctor
branch
from
b2ffed7 to
2f54f64
Compare
| template<scalar_value S> | ||
| EVE_FORCEINLINE explicit logical(S v) noexcept | ||
| //! Construct from a scalar logical | ||
| template<typename U> |
There was a problem hiding this comment.
Shouldn't this be scalar_value ?
jfalcou
added
the
release-candidate
| @@ -255,7 +255,7 @@ named_shuffle1_test(eve::as<T>, NamedShuffle named_shuffle, auto... extra_args_g | |||
| named_shuffle1_test_one_input<supports_G_eq_T_Size>(x, named_shuffle, extra_args_gen...); | |||
|
|
|||
| // false, true, false, false, true, true | |||
| eve::logical<T> mask {[](int i, int) { return std::countl_zero((unsigned)i) & 1; }}; | |||
| eve::logical<T> mask {[](int i, int) { return (std::countl_zero((unsigned)i) & 1) != 0; }}; | |||
There was a problem hiding this comment.
Oh - but my lamda generation. Can I have my lambda generation maybe?
There was a problem hiding this comment.
The issue is that the lambda returns an int, not a bool. The lanbda ctor is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.