Pass enclosing instance types to DisplayNameGenerators #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
marc/4130-display-name-generator-runtime-enclosing-types
branch
from
4d62a3d to
90f96dc
Compare
sbrannen
requested changes
Jan 25, 2025
There was a problem hiding this comment.
Thanks for putting this together, @marcphilipp.
I reviewed the PR in the browser and made some suggestions for minor improvements regarding Javadoc.
Regarding the implementation, that also looks good (at least as far as I can tell within the browser), and the new tests reflect what I'd expect. 👍
documentation/src/docs/asciidoc/release-notes/release-notes-5.12.0-M1.adoc
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
...sts/src/test/java/org/junit/jupiter/api/IndicativeSentencesRuntimeEnclosingTypeTestCase.java
Outdated
Show resolved
Hide resolved
6 tasks
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
marcphilipp
commented
Jan 25, 2025
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
sbrannen
requested changes
Jan 26, 2025
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/DisplayNameGenerator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
marcphilipp
deleted the
marc/4130-display-name-generator-runtime-enclosing-types
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #4130.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations